Ticket #314 (new defect)

Opened 17 years ago

Last modified 16 years ago

No error when using a xml custom event type not defined

Reported by: cfjedimaster Owned by:
Priority: normal Milestone: Experimental
Version: 3.1.185 Severity: normal
Keywords: Cc:

Description

If you typo and try to use an xml based custom event type that doesn't exist, the error you get doesn't make this clear:

"invalid component definition, can't find authenticatedEvent"

Maybe behind the scenes xml based CETs act like componnent based ones, but since most people will be using xml, the error should be clear.

It would be even MORE helpful if it told you the list of known CETs. In my case it would have been great since I had tried to use authenticedEvent as the CET, whereas the name was authenticedRequest.

Change History

Changed 16 years ago by DanWilson

I think we ended up getting rid of that error and just doing nothing when an event type as called but not yet defined.

It was pretty much the only way we could get scaffolding to work because we must load the generated scaffolding definitions first, so they can be appropriately overridden by the developer.

I'm going to leave this open and we'll have an internal discussion about it to see what improvements can be made.

Changed 16 years ago by DanWilson

  • milestone set to 3.1.x-next-patch

Changed 16 years ago by boomfish

  • severity changed from blocker to normal
  • summary changed from Error when using a xml custom event type not defined to No error when using a xml custom event type not defined
  • priority changed from highest to normal
  • version set to 3.1.185
  • milestone changed from 3.1.x-next-patch to Experimental
  • owner somebody deleted

Confusing error messages (or lack of an error message) from incorrect code may be a defect, but it's certainly not a high priority blocker.

I think I'd like to see a warning in the debug log for this situation. Unfortunately it looks like the event context which stores the debug log is out of scope of the XML module loader.

Since the error message had to be removed to get scaffolding to work, fixing it would involve changes to code used for scaffolding. That code is being currently being revised in an experimental branch so I'm putting this ticket into the experimental milestone until we get a better idea of when it can be fixed in a release.

Changed 16 years ago by cfjedimaster

Since scaffolding is turned off by default, wouldn't it make sense to at least throw an error when it is disabled?

Note: See TracTickets for help on using tickets.