Ticket #269 (closed defect: fixed)

Opened 19 years ago

Last modified 14 years ago

Reactor Adaptor read method is incorrect

Reported by: dhughes Owned by: somebody
Priority: highest Milestone:
Version: Severity: blocker
Keywords: Cc:

Description

The ReactorAdaptor?.cfc receives a structure of primaryKeys (which is not always 100% true). It then loops over those values and calls the setters on the reactor record. Once the setters are populated the load method is called. The problem is that the load method only works against primary keys by default. So, if you pass in any values that are not PKs then load will disregard them.

A better solution is to not set the setters, but to call load(argumentCollection=primaryKeys). This will load based on the provided data.

I've attached a working fix to this that builds upon other recently submitted fixes to the ReactorAdaptor?.

Attachments

ReactorAdapter.cfc (19.9 kB) - added by dhughes 19 years ago.

Change History

Changed 19 years ago by dhughes

Changed 19 years ago by dhughes

as an extra note, the reactor record's delete method works the same way, so the current delete method on reactorAdaptor is making an unneeded read before deleting.

Changed 19 years ago by joe.rinehart

  • status changed from new to closed
  • resolution set to fixed

Fixed along with #264 and #265 as part of [289]

Changed 16 years ago by cfgrok

  • milestone User Reported Issues (with full information) deleted

Milestone User Reported Issues (with full information) deleted

Note: See TracTickets for help on using tickets.